Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: NodeInfo cleanup #2370

Merged
merged 3 commits into from
Sep 19, 2023
Merged

feat: NodeInfo cleanup #2370

merged 3 commits into from
Sep 19, 2023

Conversation

benesjan
Copy link
Contributor

@benesjan benesjan commented Sep 18, 2023

Here is what NodeInfo looks like after the cleanup:

% yarn start get-node-info

Node Info:

Sandbox Version: 0.1.0
Compatible Nargo Version: 0.11.1-aztec.0
Chain Id: 31337
Protocol Version: 1
Rollup Address: 0x0dcd1bf9a1b36ce34237eeafef220932846bcd82

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@benesjan benesjan force-pushed the janb/nodeinfo-cleanup branch from 12ec719 to f01504d Compare September 18, 2023 15:39
@benesjan benesjan marked this pull request as draft September 18, 2023 15:48
@benesjan benesjan marked this pull request as ready for review September 18, 2023 16:00
@benesjan benesjan force-pushed the janb/nodeinfo-cleanup branch from f01504d to 6194cd7 Compare September 18, 2023 16:02
*/
client: string;
version: number;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe rename this to protocolVersion?

@benesjan benesjan enabled auto-merge (squash) September 19, 2023 08:53
@benesjan benesjan merged commit 89fe978 into master Sep 19, 2023
@benesjan benesjan deleted the janb/nodeinfo-cleanup branch September 19, 2023 09:07
PhilWindle pushed a commit that referenced this pull request Sep 19, 2023
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.7.8</summary>

##
[0.7.8](aztec-packages-v0.7.7...aztec-packages-v0.7.8)
(2023-09-19)


### Features

* `NodeInfo` cleanup
([#2370](#2370))
([89fe978](89fe978))
* Allow custom ports in sandbox
([#2393](#2393))
([41ef378](41ef378))
* Allow tracing build system with [debug ci]
([#2389](#2389))
([ce311a9](ce311a9))
* **docs:** Show current noir version for aztec in docs
([#2379](#2379))
([5c7b2ab](5c7b2ab))


### Bug Fixes

* Build script exiting on failed grep
([#2384](#2384))
([e70a781](e70a781))
* Bump e2e_sandbox_example.test.ts timeout
([#2391](#2391))
([9a1bb62](9a1bb62))
* Compile script for the unboxed project
([#2380](#2380))
([2801da2](2801da2))
* Force_deploy_build error
([#2375](#2375))
([4d1cbf9](4d1cbf9))
* Update aztec sandbox getting started markdown
([#2374](#2374))
([a3c6bcf](a3c6bcf))


### Miscellaneous

* Adds on-brand design to private token project
([#2355](#2355))
([072e313](072e313))
* Docs restructure
([#2322](#2322))
([1368b55](1368b55))


### Documentation

* Updated noirup command
([#2339](#2339))
([5308c21](5308c21))
</details>

<details><summary>barretenberg.js: 0.7.8</summary>

##
[0.7.8](barretenberg.js-v0.7.7...barretenberg.js-v0.7.8)
(2023-09-19)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>barretenberg: 0.7.8</summary>

##
[0.7.8](barretenberg-v0.7.7...barretenberg-v0.7.8)
(2023-09-19)


### Features

* Allow tracing build system with [debug ci]
([#2389](#2389))
([ce311a9](ce311a9))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants