-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: NodeInfo
cleanup
#2370
Merged
Merged
feat: NodeInfo
cleanup
#2370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benesjan
force-pushed
the
janb/nodeinfo-cleanup
branch
from
September 18, 2023 15:39
12ec719
to
f01504d
Compare
benesjan
force-pushed
the
janb/nodeinfo-cleanup
branch
from
September 18, 2023 16:02
f01504d
to
6194cd7
Compare
PhilWindle
approved these changes
Sep 19, 2023
*/ | ||
client: string; | ||
version: number; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe rename this to protocolVersion
?
PhilWindle
pushed a commit
that referenced
this pull request
Sep 19, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.7.8</summary> ## [0.7.8](aztec-packages-v0.7.7...aztec-packages-v0.7.8) (2023-09-19) ### Features * `NodeInfo` cleanup ([#2370](#2370)) ([89fe978](89fe978)) * Allow custom ports in sandbox ([#2393](#2393)) ([41ef378](41ef378)) * Allow tracing build system with [debug ci] ([#2389](#2389)) ([ce311a9](ce311a9)) * **docs:** Show current noir version for aztec in docs ([#2379](#2379)) ([5c7b2ab](5c7b2ab)) ### Bug Fixes * Build script exiting on failed grep ([#2384](#2384)) ([e70a781](e70a781)) * Bump e2e_sandbox_example.test.ts timeout ([#2391](#2391)) ([9a1bb62](9a1bb62)) * Compile script for the unboxed project ([#2380](#2380)) ([2801da2](2801da2)) * Force_deploy_build error ([#2375](#2375)) ([4d1cbf9](4d1cbf9)) * Update aztec sandbox getting started markdown ([#2374](#2374)) ([a3c6bcf](a3c6bcf)) ### Miscellaneous * Adds on-brand design to private token project ([#2355](#2355)) ([072e313](072e313)) * Docs restructure ([#2322](#2322)) ([1368b55](1368b55)) ### Documentation * Updated noirup command ([#2339](#2339)) ([5308c21](5308c21)) </details> <details><summary>barretenberg.js: 0.7.8</summary> ## [0.7.8](barretenberg.js-v0.7.7...barretenberg.js-v0.7.8) (2023-09-19) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>barretenberg: 0.7.8</summary> ## [0.7.8](barretenberg-v0.7.7...barretenberg-v0.7.8) (2023-09-19) ### Features * Allow tracing build system with [debug ci] ([#2389](#2389)) ([ce311a9](ce311a9)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is what NodeInfo looks like after the cleanup:
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.